Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848AbdHVVls (ORCPT ); Tue, 22 Aug 2017 17:41:48 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:35721 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbdHVVlr (ORCPT ); Tue, 22 Aug 2017 17:41:47 -0400 Subject: Re: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts To: Eugeniy Paltsev , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "Alexey Brodkin" , Rob Herring , "Mark Rutland" , "devicetree@vger.kernel.org" References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> From: Vineet Gupta Message-ID: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> Date: Tue, 22 Aug 2017 14:40:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.10.161.108] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2396 Lines: 90 On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > Set cpu frequency explicitly via "cpu-freq" param in cpu 0 node > in device tree. > > We add "cpu-freq" only to cpu 0 as all cpus are clocking from same > clock source (same pll in our case). > > We override cpus node in skeleton as we don't need this change for > nsim. Given that you added a generic feature as part of 1/5 - do other platforms abilis/nps need corresponding fixups as this one ! > > Signed-off-by: Eugeniy Paltsev > --- > arch/arc/boot/dts/axc003.dtsi | 13 +++++++++++++ > arch/arc/boot/dts/axc003_idu.dtsi | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/arch/arc/boot/dts/axc003.dtsi b/arch/arc/boot/dts/axc003.dtsi > index dca7e39..7c7411c 100644 > --- a/arch/arc/boot/dts/axc003.dtsi > +++ b/arch/arc/boot/dts/axc003.dtsi > @@ -17,6 +17,19 @@ > #address-cells = <2>; > #size-cells = <2>; > > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + device_type = "cpu"; > + compatible = "snps,archs38"; > + reg = <0>; > + cpu-freq = <100000000>; > + clocks = <&core_clk>; > + }; > + }; > + > cpu_card { > compatible = "simple-bus"; > #address-cells = <1>; > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi b/arch/arc/boot/dts/axc003_idu.dtsi > index 5b56bef..44bc01e 100644 > --- a/arch/arc/boot/dts/axc003_idu.dtsi > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > @@ -17,6 +17,41 @@ > #address-cells = <2>; > #size-cells = <2>; > > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* > + * "cpu-freq" was added only to cpu 0 as all cpus are clocking > + * from same clock source (same pll (core_clk) in our case). > + */ > + cpu@0 { > + device_type = "cpu"; > + compatible = "snps,archs38"; > + reg = <0>; > + cpu-freq = <100000000>; > + clocks = <&core_clk>; > + }; > + cpu@1 { > + device_type = "cpu"; > + compatible = "snps,archs38"; > + reg = <1>; > + clocks = <&core_clk>; > + }; > + cpu@2 { > + device_type = "cpu"; > + compatible = "snps,archs38"; > + reg = <2>; > + clocks = <&core_clk>; > + }; > + cpu@3 { > + device_type = "cpu"; > + compatible = "snps,archs38"; > + reg = <3>; > + clocks = <&core_clk>; > + }; > + }; > + > cpu_card { > compatible = "simple-bus"; > #address-cells = <1>;