Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbdHVWda (ORCPT ); Tue, 22 Aug 2017 18:33:30 -0400 Received: from www62.your-server.de ([213.133.104.62]:40698 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbdHVWd3 (ORCPT ); Tue, 22 Aug 2017 18:33:29 -0400 Message-ID: <599CB12D.8090301@iogearbox.net> Date: Wed, 23 Aug 2017 00:33:17 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Daney , Colin King , Ralf Baechle , David Daney , "David S . Miller" , linux-mips@linux-mips.org CC: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] MIPS,bpf: fix missing break in switch statement References: <20170822220349.5648-1-colin.king@canonical.com> <93479b06-c3a2-a08a-fe5c-d8f155efeacc@caviumnetworks.com> In-Reply-To: <93479b06-c3a2-a08a-fe5c-d8f155efeacc@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 23 On 08/23/2017 12:29 AM, David Daney wrote: > On 08/22/2017 03:03 PM, Colin King wrote: >> From: Colin Ian King >> >> There is a missing break causing a fall-through and setting >> ctx.use_bbit_insns to the wrong value. Fix this by adding the >> missing break. >> >> Detected with cppcheck: >> "Variable 'ctx.use_bbit_insns' is reassigned a value before the old >> one has been used. 'break;' missing?" >> >> Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.") >> Signed-off-by: Colin Ian King > > Crap! That slipped through. Thanks for fixing it. > > Tested and ... > > Acked-by: David Daney Colin, can you send this with David's ACK to netdev in Cc so it lands in patchwork? It's for net-next tree. Thanks!