Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbdHWBk2 (ORCPT ); Tue, 22 Aug 2017 21:40:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57512 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753164AbdHWBk1 (ORCPT ); Tue, 22 Aug 2017 21:40:27 -0400 Date: Tue, 22 Aug 2017 18:40:31 -0700 From: Greg KH To: laurentiu.tudor@nxp.com Cc: stuyoder@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, agraf@suse.de, ioana.ciornei@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns Message-ID: <20170823014031.GA14400@kroah.com> References: <20170817115504.4308-1-laurentiu.tudor@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170817115504.4308-1-laurentiu.tudor@nxp.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 360 Lines: 12 On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote: > From: Laurentiu Tudor > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except > this place, so fix it. You will just get someone else fixing it as it is not what checkpatch recommends, so just leave it as-is please. thanks, greg k-h