Date: Wed, 2 Jul 2003 11:34:57 +0100
From: viro@parcelfarce.linux.theplanet.co.uk
To: Jan Kratochvil 
	<rcpt-linux-fsdevel.AT.vger.kernel.org@jankratochvil.net>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
       chaffee@cs.berkeley.edu, zippel@linux-m68k.org
Subject: Re: [PATCH] vfat+affs case preservation
Message-ID: <20030702103457.GS27348@parcelfarce.linux.theplanet.co.uk>
References: <20030702102538.GA16711@exuhome.dyn.jankratochvil.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030702102538.GA16711@exuhome.dyn.jankratochvil.net>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1003
Lines: 27

On Wed, Jul 02, 2003 at 12:25:38PM +0200, Jan Kratochvil wrote:
> +/* We have to always do the revalidate as after unlink (etc.) there still may
> + * exist other case-different dentries for the same inode. It would be also
> + * possible to discard such aliases by going through d_alias links during the
> + * unlink. "strictcase" does not have case-different dentries but "longna~1"
> + * style aliases still exist there.
> + */

> -	alias = d_find_alias(inode);
> -	if (alias) {
> -		if (d_invalidate(alias)==0)
> -			dput(alias);
> -		else {
> -			iput(inode);
> -			unlock_kernel();
> -			return alias;
> -		}
> -		
> -	}

Broken.   With that we can get two active dentries for the same directory.
There goes any cache coherency, with all usual results.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/