Message-ID: <1503455625.6933.12.camel@perches.com>
Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp()
 returns
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>, laurentiu.tudor@nxp.com
Cc: stuyoder@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, agraf@suse.de, ioana.ciornei@nxp.com,
        linux-arm-kernel@lists.infradead.org
Date: Tue, 22 Aug 2017 19:33:45 -0700
In-Reply-To: <20170823014031.GA14400@kroah.com>
References: <20170817115504.4308-1-laurentiu.tudor@nxp.com>
         <20170823014031.GA14400@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 529
Lines: 14

On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > 
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
> 
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No.  That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.