Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbdHWDBd (ORCPT ); Tue, 22 Aug 2017 23:01:33 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:40619 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753162AbdHWDBc (ORCPT ); Tue, 22 Aug 2017 23:01:32 -0400 Date: Wed, 23 Aug 2017 10:56:10 +0800 From: Jisheng Zhang To: John Stultz CC: Greg KH , Arve =?UTF-8?B?SGrDuG5uZXbDpWc=?= , Riley Andrews , , lkml , "linux-arm-kernel@lists.infradead.org" Subject: Re: [EXT] Re: [PATCH] binder: let ANDROID_BINDER_IPC_32BIT be selectable on 32bit ARM Message-ID: <20170823105610.11f54366@xhacker> In-Reply-To: References: <20170808110305.2748-1-jszhang@marvell.com> <20170823015108.GA18228@kroah.com> <20170823103420.6ffb5ce7@xhacker> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-22_09:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708230043 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2301 Lines: 57 On Tue, 22 Aug 2017 19:56:07 -0700 John Stultz wrote: > External Email > > ---------------------------------------------------------------------- > On Tue, Aug 22, 2017 at 7:34 PM, Jisheng Zhang wrote: > > On Tue, 22 Aug 2017 18:51:08 -0700 Greg KH wrote: > > > >> On Tue, Aug 08, 2017 at 07:03:05PM +0800, Jisheng Zhang wrote: > >> > As noted in commit d0bdff0db809 ("staging: Fix build issues with new > >> > binder API"), we can add back the choice for 32bit ARM "once a 64bit > >> > __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM: > >> > 8091/2: add get_user() support for 8 byte types") has added the > >> > support, so it's time to let ANDROID_BINDER_IPC_32BIT be selectable on > >> > 32bit ARM > >> > >> Ok, but: > >> > >> > > >> > Signed-off-by: Jisheng Zhang > >> > --- > >> > drivers/android/Kconfig | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > >> > index 832e885349b1..aca5dc30b97b 100644 > >> > --- a/drivers/android/Kconfig > >> > +++ b/drivers/android/Kconfig > >> > @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES > >> > therefore logically separated from the other devices. > >> > > >> > config ANDROID_BINDER_IPC_32BIT > >> > - bool > >> > + bool "Use old (Android 4.4 and earlier) 32-bit binder API" > >> > depends on !64BIT && ANDROID_BINDER_IPC > >> > >> You don't actually change the depends line :( > >> > >> Please fix up, and test it, and then resend. > > > > IHOM, the dependency is correct: 64bit platforms don't support > > ANDROID_BINDER_IPC_32BIT. What do you think? > > I think this indicates the commit message is unclear. > > Part of it is that the config is inverted from the description. The > patch doesn't enable the 32bit legacy binder ABI on 32bit systems, it > just allows the option to be unselected, so that the 64bit ABI will be > used on 32bit systems. > > Conceptually I don't have an objection to the change (though maybe try > to rework the commit message), but I don't have anything to actually > test it on right now, so I'm hesitant to ack it. > I have tested it on Marvell Berlin 32bit platform: the 64bit binder IPC works fine on our 32bit platform.