Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbdHWFip (ORCPT ); Wed, 23 Aug 2017 01:38:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35228 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbdHWFin (ORCPT ); Wed, 23 Aug 2017 01:38:43 -0400 Date: Tue, 22 Aug 2017 22:38:47 -0700 From: Greg KH To: Joe Perches Cc: laurentiu.tudor@nxp.com, stuyoder@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, agraf@suse.de, ioana.ciornei@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns Message-ID: <20170823053847.GF23426@kroah.com> References: <20170817115504.4308-1-laurentiu.tudor@nxp.com> <20170823014031.GA14400@kroah.com> <1503455625.6933.12.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503455625.6933.12.camel@perches.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 23 On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote: > On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote: > > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote: > > > From: Laurentiu Tudor > > > > > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except > > > this place, so fix it. > > > > You will just get someone else fixing it as it is not what checkpatch > > recommends, so just leave it as-is please. > > No. That's not correct. > > checkpatch does not make a recommendation about > style use with the strcmp family of functions. Ah, ok, nevermind then... Laurentiu, can you resend this? thanks, greg k-h