Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753685AbdHWI30 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Aug 2017 04:29:26 -0400
Received: from mail-oi0-f54.google.com ([209.85.218.54]:36272 "EHLO
        mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753484AbdHWI3Y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Aug 2017 04:29:24 -0400
MIME-Version: 1.0
In-Reply-To: <20170821193142.29688-2-danilokrummrich@dk-develop.de>
References: <20170821193142.29688-1-danilokrummrich@dk-develop.de> <20170821193142.29688-2-danilokrummrich@dk-develop.de>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 23 Aug 2017 10:29:23 +0200
Message-ID: <CACRpkdZ6RJurzXnOzsG=b3cO0LhapE_kV2ds=U-Gpv3e84x1nw@mail.gmail.com>
Subject: Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus
To: Danilo Krummrich <danilokrummrich@dk-develop.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux Input <linux-input@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rob Herring <robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 495
Lines: 17

On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich
<danilokrummrich@dk-develop.de> wrote:

> +static int __ps2_gpio_write(struct serio *serio, unsigned char val)
> +static int ps2_gpio_write(struct serio *serio, unsigned char val)

I never like the random use of __prefixes as they have unclear
semantics.

I would name it something concise.

Anyways, that is up to the subsystem maintainer.
>From a GPIO point of view:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij