Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753980AbdHWKDC (ORCPT ); Wed, 23 Aug 2017 06:03:02 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39926 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753864AbdHWKC6 (ORCPT ); Wed, 23 Aug 2017 06:02:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E8A3560115 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arvind Yadav Cc: davem@davemloft.net, Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, jon.maloy@ericsson.com, ying.xue@windriver.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops References: <1503482375-19983-1-git-send-email-arvind.yadav.cs@gmail.com> <1503482375-19983-4-git-send-email-arvind.yadav.cs@gmail.com> Date: Wed, 23 Aug 2017 13:02:49 +0300 In-Reply-To: <1503482375-19983-4-git-send-email-arvind.yadav.cs@gmail.com> (Arvind Yadav's message of "Wed, 23 Aug 2017 15:29:35 +0530") Message-ID: <87378iy52u.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 456 Lines: 15 Arvind Yadav writes: > genl_ops are not supposed to change at runtime. All functions > working with genl_ops provided by work with > const genl_ops. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > net/tipc/netlink_compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Using the prefix "rsi:" looks wrong for this patch. -- Kalle Valo