Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801AbdHWKF1 (ORCPT ); Wed, 23 Aug 2017 06:05:27 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:38509 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753657AbdHWKFZ (ORCPT ); Wed, 23 Aug 2017 06:05:25 -0400 Subject: Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops To: Kalle Valo References: <1503482375-19983-1-git-send-email-arvind.yadav.cs@gmail.com> <1503482375-19983-4-git-send-email-arvind.yadav.cs@gmail.com> <87378iy52u.fsf@kamboji.qca.qualcomm.com> Cc: davem@davemloft.net, Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, jon.maloy@ericsson.com, ying.xue@windriver.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org From: Arvind Yadav Message-ID: <34315266-d6be-0c88-4d6e-129c1300e3f7@gmail.com> Date: Wed, 23 Aug 2017 15:35:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <87378iy52u.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 562 Lines: 18 Hi, On Wednesday 23 August 2017 03:32 PM, Kalle Valo wrote: > Arvind Yadav writes: > >> genl_ops are not supposed to change at runtime. All functions >> working with genl_ops provided by work with >> const genl_ops. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav >> --- >> net/tipc/netlink_compat.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Using the prefix "rsi:" looks wrong for this patch. Thanks for pointing. I will update. > ~arvind