Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753945AbdHWLUx (ORCPT ); Wed, 23 Aug 2017 07:20:53 -0400 Received: from ozlabs.org ([103.22.144.67]:57557 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbdHWLUw (ORCPT ); Wed, 23 Aug 2017 07:20:52 -0400 From: Michael Ellerman To: Michael Bringmann , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Michael Bringmann , John Allen , Nathan Fontenot , 9e5050e1-e0cc-0e0e-7b31-5dcb38b307f4@linux.vnet.ibm.com Subject: Re: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations In-Reply-To: <83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com> References: <83b05ed2-8d18-3d5c-2003-b022d0d55eb2@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 23 Aug 2017 21:20:50 +1000 Message-ID: <87h8wyy1gt.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 36 Michael Bringmann writes: > To: linuxppc-dev@lists.ozlabs.org > > From: Michael Bringmann > > To: linux-kernel@vger.kernel.org > Cc: Michael Ellerman > Cc: Michael Bringmann > Cc: John Allen > Cc: Nathan Fontenot > Subject: [PATCH V9 2/2] powerpc/nodes: Ensure enough nodes avail for operations > > powerpc/nodes: On systems like PowerPC which allow 'hot-add' of CPU > or memory resources, it may occur that the new resources are to be > inserted into nodes that were not used for these resources at bootup. > In the kernel, any node that is used must be defined and initialized > at boot. > > This patch extracts the value of the lowest domain level (number of > allocable resources) from the "rtas" device tree property > "ibm,max-associativity-domains" to use as the maximum number of nodes > to setup as possibly available in the system. This new setting will > override the instruction, Thanks for implementing my suggestion of using "ibm,max-associativity-domains". However I don't think it's correct to use the lowest domain level. It's not very clearly specified in PAPR, but I think you need to treat it like an associativity property and index into based on the associativity reference points. You should be able to use min_common_depth as the index. cheers