Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931AbdHWLYV (ORCPT ); Wed, 23 Aug 2017 07:24:21 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:54195 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbdHWLYT (ORCPT ); Wed, 23 Aug 2017 07:24:19 -0400 From: Eugeniy Paltsev To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , Alexey Brodkin , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Thread-Topic: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Thread-Index: AQHTFRgj1b8p3G9ImU2lvTxOKFI3q6KQ0u0AgADmDgA= Date: Wed, 23 Aug 2017 11:24:15 +0000 Message-ID: <1503487454.2586.58.camel@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> In-Reply-To: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <0FCCF0542B240B4EA68F16282A2C369C@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7NBOQ4h006772 Content-Length: 2873 Lines: 106 On Tue, 2017-08-22 at 14:40 -0700, Vineet Gupta wrote: > On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > > Set cpu frequency explicitly via "cpu-freq" param in cpu 0 node > > in device tree. > > > > We add "cpu-freq" only to cpu 0 as all cpus are clocking from same > > clock source (same pll in our case). > > > > We override cpus node in skeleton as we don't need this change for > > nsim. > > Given that you added a generic feature as part of 1/5 - do other > platforms  > abilis/nps need corresponding fixups as this one ! Actually no. If cpu 0 node don't have "cpu-freq" property we simply print cpu frequency and don't try to change it. So we can left other dts untouched. > > > > Signed-off-by: Eugeniy Paltsev > > --- > >   arch/arc/boot/dts/axc003.dtsi     | 13 +++++++++++++ > >   arch/arc/boot/dts/axc003_idu.dtsi | 35 > > +++++++++++++++++++++++++++++++++++ > >   2 files changed, 48 insertions(+) > > > > diff --git a/arch/arc/boot/dts/axc003.dtsi > > b/arch/arc/boot/dts/axc003.dtsi > > index dca7e39..7c7411c 100644 > > --- a/arch/arc/boot/dts/axc003.dtsi > > +++ b/arch/arc/boot/dts/axc003.dtsi > > @@ -17,6 +17,19 @@ > >    #address-cells = <2>; > >    #size-cells = <2>; > >    > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu@0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > >    cpu_card { > >    compatible = "simple-bus"; > >    #address-cells = <1>; > > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi > > b/arch/arc/boot/dts/axc003_idu.dtsi > > index 5b56bef..44bc01e 100644 > > --- a/arch/arc/boot/dts/axc003_idu.dtsi > > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > > @@ -17,6 +17,41 @@ > >    #address-cells = <2>; > >    #size-cells = <2>; > >    > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* > > +  * "cpu-freq" was added only to cpu 0 as all cpus > > are clocking > > +  * from same clock source (same pll (core_clk) in > > our case). > > +  */ > > + cpu@0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + cpu@1 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <1>; > > + clocks = <&core_clk>; > > + }; > > + cpu@2 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <2>; > > + clocks = <&core_clk>; > > + }; > > + cpu@3 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <3>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > >    cpu_card { > >    compatible = "simple-bus"; > >    #address-cells = <1>; > > --  Eugeniy Paltsev