Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754134AbdHWMW5 (ORCPT ); Wed, 23 Aug 2017 08:22:57 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:54486 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753883AbdHWMWy (ORCPT ); Wed, 23 Aug 2017 08:22:54 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: wulf@rock-chips.com X-FST-TO: daniel.meng@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wulf@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 1/3] dt-bindings: usb: add DT binding for RK3328 dwc3 controller To: William Wu , heiko@sntech.de, balbi@kernel.org, gregkh@linuxfoundation.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, frank.wang@rock-chips.com, huangtao@rock-chips.com, daniel.meng@rock-chips.com References: <1503322566-31489-1-git-send-email-william.wu@rock-chips.com> <1503322566-31489-2-git-send-email-william.wu@rock-chips.com> From: wlf Message-ID: <4406bd06-8b2b-9e30-f0b4-b41596622782@rock-chips.com> Date: Wed, 23 Aug 2017 20:22:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1503322566-31489-2-git-send-email-william.wu@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 46 Dear Balbi & Gregkh, 在 2017年08月21日 21:36, William Wu 写道: > Adds the device tree bindings description for RK3328 and > compatible USB DWC3 controller. > > Signed-off-by: William Wu > --- > Changes in v3: > - Add this for separate usb dt-bindings patch. > > Changes in v2: > - None > > Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > index 0536a93..d6b2e47 100644 > --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > @@ -1,7 +1,9 @@ > Rockchip SuperSpeed DWC3 USB SoC controller > > Required properties: > -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC > +- compatible: should be one of the following: > + - "rockchip,rk3399-dwc3": for rk3399 SoC > + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC > - clocks: A list of phandle + clock-specifier pairs for the > clocks listed in clock-names > - clock-names: Should contain the following: Could you help to reviewed this patch? According to Heiko's suggestion, this patch need to be submitted to usb tree or at least get an Ack from you. Thank you! -- 吴良峰 William.Wu 福建省福州市铜盘路软件大道89号软件园A区21号楼 No.21 Building, A District, No.89,software Boulevard Fuzhou,Fujian, PRC 手机: 13685012275 座机: 0591-83991906-8520 邮件:wulf@rock-chips.com