Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754022AbdHWM13 (ORCPT ); Wed, 23 Aug 2017 08:27:29 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:37665 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753935AbdHWM11 (ORCPT ); Wed, 23 Aug 2017 08:27:27 -0400 MIME-Version: 1.0 In-Reply-To: <20170822202318.25439-1-shuahkh@osg.samsung.com> References: <20170822202318.25439-1-shuahkh@osg.samsung.com> From: Benjamin Gaignard Date: Wed, 23 Aug 2017 14:27:26 +0200 Message-ID: Subject: Re: [PATCH] selftests: timers: remove rtctest_setdate from run_destructive_tests To: Shuah Khan Cc: John Stultz , Shuah Khan , Thomas Gleixner , Stephen Boyd , linux-kselftest@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7NCRZSu010479 Content-Length: 1918 Lines: 52 2017-08-22 22:23 GMT+02:00 Shuah Khan : > Remove rtctest_setdate from run_destructive_tests target. Leave it in > TEST_GEN_PROGS_EXTENDED to be included in the install targets. > > Suggested-by: John Stultz > Signed-off-by: Shuah Khan Reviewed-by: Benjamin Gaignard > --- > tools/testing/selftests/timers/Makefile | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile > index 4ed9e45c7f38..de85358ae937 100644 > --- a/tools/testing/selftests/timers/Makefile > +++ b/tools/testing/selftests/timers/Makefile > @@ -6,15 +6,17 @@ LDFLAGS += -lrt -lpthread -lm > TEST_GEN_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat mqueue-lat \ > inconsistency-check raw_skew threadtest rtctest > > -TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew \ > +DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \ > skew_consistency clocksource-switch freq-step leap-a-day \ > - leapcrash set-tai set-2038 set-tz rtctest_setdate > + leapcrash set-tai set-2038 set-tz > + > +TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS) rtctest_setdate > > > include ../lib.mk > > define RUN_DESTRUCTIVE_TESTS > - @for TEST in $(TEST_GEN_PROGS_EXTENDED); do \ > + @for TEST in $(DESTRUCTIVE_TESTS); do \ > BASENAME_TEST=`basename $$TEST`; \ > if [ ! -x $$BASENAME_TEST ]; then \ > echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\ > -- > 2.11.0 > -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog