Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046AbdHWN0G (ORCPT ); Wed, 23 Aug 2017 09:26:06 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:56015 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754027AbdHWN0F (ORCPT ); Wed, 23 Aug 2017 09:26:05 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Ping-Ke Shih , Larry Finger , Yan-Hsuan Chuang , Birming Chiu , Shaofu , Steven Ting , Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: rtlwifi: simplify logical operation Date: Wed, 23 Aug 2017 15:22:53 +0200 Message-Id: <20170823132337.517466-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170823132337.517466-1-arnd@arndb.de> References: <20170823132337.517466-1-arnd@arndb.de> X-Provags-ID: V03:K0:VFS2xiN6L9ngupkRzyPq+e+3fdqPEXGAr63cAGv9oyzWxOqk+QS wB+VOpuKzYaDNjouJIBY7L8Vb9cPFHJDxtcPH5Rr4w+A1slPyiELziWc+wOJP7ca8XbyL+l NGUKDbjEvvcUQeFztCHz5U1KCDNHJGGb7K9t27vEis1FWDi8e4L2ZuFXiTYTT0OqJRaRU7Y uvjcEZOK9cs6tdNHmlDRw== X-UI-Out-Filterresults: notjunk:1;V01:K0:1xVrwFR4yAU=:Qs30eCZ8eRi3QGj82+PzBg vBmOwL+pWSjBK0REhrwaBv1gZJ6FEoaZyWtv/iE7aTi9PqvTKYM3IriBRp5sl1NOkhcA6vQnX 6X/hZq+F9swMYtAlzYwu9LMe2oXaMxp/mXbl8VxKt1L39+nVKGxmdkVZlpYqGEAGyF9Dzp0qf kK0jehAyH76Gnnn3trBHAlBMbTM5XDAKZHEBmC0PfFkTZnNPJaaFWf0Mfn/u6xNGXbHScPuSt oltemhJq1RduqYQYgPujHSxce2az80PcJ6FYWfUEx7KWKm8GqKQG2r18wLIbvCItNeLdnVOIw oWYlOBlalXv5vWbbKDhEuqY239irAgmjjWqZ02a104iXmk0YG2ZVv5qqD9YNU/dTvDfCz8wmo 33ooFIJlVnuOVc6Oqwvt3cb6FShYML3GXSYlmMNphMKLCpdkmwLn7I6KI4v/R/BhY9OkIG7sm PaYmIidW3ocvIcqeWXpe+ZLNvF48+z6Nf9qn8QloJ+SUqkJit7kfiRZnEtHFBOv/EFmLUShrL 6q93eVkize6AIIu6MNAgFNR9ymrvy60y77CN+E/YLV/5y50Lson8aYVg7onqjypIQoAznwv/l 5/5Rz/08Loh9Iug2AgA49hB3TMycIdv4Flvcl/Pt0hKCwsWC75QuucFyjk/3UGNHkXDSk1rD+ fFm3hWz+rMIcp05hNxhkDnJd7gMmFDT4wUD+4AvPsOYk2kTgomPSoqgRQHD6AP6iHdkqDbPSi nKByxAzREkDE353cNjPu0ouO57o4vflHuknrYw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 37 gcc notices a very complicated way to check a value for being equal to one, and warns about it: drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c: In function 'halbtc8822b1ant_set_ext_ant_switch': drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: error: '~' on a boolean expression [-Werror=bool-operation] ~switch_polatiry_inverse : ^ drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c:2105:9: note: did you mean to use logical not? ~switch_polatiry_inverse : ^ This simplifies this expression to make it more readable and to make gcc happy. Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") Signed-off-by: Arnd Bergmann --- drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c b/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c index 933d188d52b4..157395b85405 100644 --- a/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c +++ b/drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c @@ -2101,9 +2101,7 @@ static void halbtc8822b1ant_set_ext_ant_switch(struct btc_coexist *btcoexist, * 0xcbd[1:0] = 2b'01 => Ant to BTG, * 0xcbd[1:0] = 2b'10 => Ant to WLG */ - switch_polatiry_inverse = (rfe_type->ext_ant_switch_ctrl_polarity == 1 ? - ~switch_polatiry_inverse : - switch_polatiry_inverse); + switch_polatiry_inverse = rfe_type->ext_ant_switch_ctrl_polarity == 1; switch (pos_type) { default: -- 2.9.0