Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754142AbdHWN7T (ORCPT ); Wed, 23 Aug 2017 09:59:19 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:58469 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001AbdHWN7Q (ORCPT ); Wed, 23 Aug 2017 09:59:16 -0400 Subject: Re: [PATCH] phy: ralink: fix 64-bit build warning To: Arnd Bergmann , Kishon Vijay Abraham I , John Crispin CC: References: <20170823134019.927267-1-arnd@arndb.de> From: Harvey Hunt Message-ID: <424b7b28-ff77-b7e6-3ae0-8173b7b0a411@imgtec.com> Date: Wed, 23 Aug 2017 14:59:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170823134019.927267-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.107] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 28 Hi Arnd, On 23/08/17 14:39, Arnd Bergmann wrote: > Casting between an 'int' and a pointer causes a warning on > 64-bit architectures in compile-testing this driver: > > drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe': > drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] > > This changes the code to cast to uintptr_t instead. This is > guaranteed to do what we want on all architectures and avoids > the warning. > > Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink") > Signed-off-by: Arnd Bergmann > --- > drivers/phy/ralink/phy-ralink-usb.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) [...] Thanks for fixing this - it was on my TODO list. Tested-by Harvey Hunt Reviewed-by Harvey Hunt Thanks, Harvey