Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754133AbdHWO2X (ORCPT ); Wed, 23 Aug 2017 10:28:23 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:37248 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066AbdHWO2V (ORCPT ); Wed, 23 Aug 2017 10:28:21 -0400 MIME-Version: 1.0 X-Originating-IP: [90.77.100.34] In-Reply-To: References: <20170615185418.13980-1-javier@dowhile0.org> <20170615185418.13980-11-javier@dowhile0.org> From: Javier Martinez Canillas Date: Wed, 23 Aug 2017 16:28:20 +0200 Message-ID: Subject: Re: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible string for I2C EEPROM To: Michal Simek Cc: Linux Kernel , Wolfram Sang , Rob Herring , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "devicetree@vger.kernel.org" , Rob Herring , Mark Rutland , Russell King , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 43 Hello Michal, On Wed, Jun 21, 2017 at 1:43 PM, Michal Simek wrote: > On 15.6.2017 20:54, Javier Martinez Canillas wrote: >> The at24 driver allows to register I2C EEPROM chips using different vendor >> and devices, but the I2C subsystem does not take the vendor into account >> when matching using the I2C table since it only has device entries. >> >> But when matching using an OF table, both the vendor and device has to be >> taken into account so the driver defines only a set of compatible strings >> using the "atmel" vendor as a generic fallback for compatible I2C devices. >> >> So add this generic fallback to the device node compatible string to make >> the device to match the driver using the OF device ID table. >> >> Signed-off-by: Javier Martinez Canillas >> [snip] >> --- a/arch/arm/boot/dts/zynq-zc706.dts >> +++ b/arch/arm/boot/dts/zynq-zc706.dts >> @@ -92,7 +92,7 @@ >> #size-cells = <0>; >> reg = <2>; >> eeprom@54 { >> - compatible = "at,24c08"; >> + compatible = "atmel,24c08"; >> reg = <0x54>; >> }; >> }; >> > > Acked-by: Michal Simek > Same question than for the other patch, could you please also apply this? Sorry for not being clear in the cover letter that the patches could be applied independently. Best regards, Javier