Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932179AbdHWObJ (ORCPT ); Wed, 23 Aug 2017 10:31:09 -0400 Received: from mga09.intel.com ([134.134.136.24]:6862 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbdHWObI (ORCPT ); Wed, 23 Aug 2017 10:31:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,417,1498546800"; d="scan'208";a="893367636" Message-ID: <1503498573.25945.69.camel@linux.intel.com> Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs From: Andy Shevchenko To: Tom Rini , linux-kernel@vger.kernel.org Cc: Bard Liao , Oder Chiou , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Mark Brown , Linus Torvalds Date: Wed, 23 Aug 2017 17:29:33 +0300 In-Reply-To: <1503453106-5564-1-git-send-email-trini@konsulko.com> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1518 Lines: 43 On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote: > Not all devices with ACPI and this combination of sound devices will > have the required information provided via ACPI.  Reintroduce the I2C > device ID to restore sound functionality on on the Chromebook 'Samus' > model. > This is a regression from v4.12 on my laptop (a Chromebook 'Samus' > that's not running ChromeOS).  My fault for getting out of the habit > of > trying -rc1 when it comes out and not spotting this sooner.  I'm not > 100% sure if this fix is correct for all cases as I'm only able to > test > my hardware here, and this does fix my laptop. Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data in the module sources") does not fix your issue? > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c > index 36e530a36c82..6f629278d982 100644 > --- a/sound/soc/codecs/rt5677.c > +++ b/sound/soc/codecs/rt5677.c > @@ -5021,6 +5021,7 @@ static int rt5677_write(void *context, unsigned > int reg, unsigned int val) >  static const struct i2c_device_id rt5677_i2c_id[] = { >   { "rt5677", RT5677 }, >   { "rt5676", RT5676 }, > + { "RT5677CE:00", RT5677 }, >   { } >  }; >  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); This one looks weird. The board code has this  sound/soc/intel/boards/bdw-rt5677.c:285:                .codec_name = "i2c-RT5677CE:00", It's clearly a match to ACPI enumerated I2C slave device. -- Andy Shevchenko Intel Finland Oy