Date: Wed, 23 Aug 2017 07:53:29 -0700
From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Tomi Valkeinen <tomi.valkeinen@ti.com>,
        linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: fix missing variable declaration
Message-ID: <20170823145328.GN6008@atomide.com>
References: <20170823132841.642239-1-arnd@arndb.de>
 <12875092.dy1RW0XmqV@avalon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12875092.dy1RW0XmqV@avalon>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 890
Lines: 24

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [170823 06:53]:
> Hi Arnd,
> 
> On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote:
> > The function that was added doesn't actually build:
> > 
> > arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev':
> > arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in
> > this function)
> > 
> > This adds a declaration for 'r' to fix it.
> > 
> > Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for
> > omapdrm")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the 
> last rebase. I'm very sorry about that :-(
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1.

Acked-by: Tony Lindgren <tony@atomide.com>