Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167AbdHWPWn (ORCPT ); Wed, 23 Aug 2017 11:22:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49219 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932081AbdHWPWl (ORCPT ); Wed, 23 Aug 2017 11:22:41 -0400 To: Christoph Hellwig Cc: Long Li , KY Srinivasan , Haiyang Zhang , "devel\@linuxdriverproject.org" , "linux-scsi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "stable\@vger.kernel.org" Subject: Re: [PATCH] storvsc: do not assume SG list is continuous when doing bounce buffers (for 4.1 stable only) From: "Martin K. Petersen" Organization: Oracle References: <1503379905-18908-1-git-send-email-longli@exchange.microsoft.com> <20170822062841.GA1061@infradead.org> <20170823064319.GA19373@infradead.org> Date: Wed, 23 Aug 2017 11:22:07 -0400 In-Reply-To: <20170823064319.GA19373@infradead.org> (Christoph Hellwig's message of "Tue, 22 Aug 2017 23:43:19 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 20 Christoph, > Ok. If the stable maintainers are ok with your small fix > I'm not going to complain too loudly. But I'm always worried about > stable trees divering too much from mainline. The seemingly innocuous transition from SG_GAPS to virt boundary has caused several data corruption regressions in the distro kernels. So has the corresponding conversion of storvsc. As a result, getting the current upstream code into 4.1 would mean backporting and testing a significant amount of both block layer and driver code. I don't think it's worth the risk. This patch is simple and the path of least resistance. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering