From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "dvyukov@google.com" <dvyukov@google.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>
Subject: Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent
 fault injection
Thread-Topic: [PATCH v2 1/2] fault-inject: Restore support for
 task-independent fault injection
Thread-Index: AQHTG5qI+aRdMEZSjky7RyvQ/PBtGqKRETOAgAEiwoA=
Date: Wed, 23 Aug 2017 17:31:00 +0000
Message-ID: <1503509459.2484.13.camel@wdc.com>
References: <20170822230043.9968-1-bart.vanassche@wdc.com>
         <20170822230043.9968-2-bart.vanassche@wdc.com>
         <CAC5umyh5r-nmKisg7bavbm320Gd1puZmPOv7q+q0yonYbzr+ZA@mail.gmail.com>
In-Reply-To: <CAC5umyh5r-nmKisg7bavbm320Gd1puZmPOv7q+q0yonYbzr+ZA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <9BCC1355337BC54D81916DFDCD8CBE6B@namprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2017 17:31:00.5153
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1721
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v7NHVtpY029121
Content-Length: 1100
Lines: 26

On Wed, 2017-08-23 at 09:10 +0900, Akinobu Mita wrote:
> 2017-08-23 8:00 GMT+09:00 Bart Van Assche <bart.vanassche@wdc.com>:
> > Certain faults should be injected independent of the context
> > in which these occur. Commit e41d58185f14 made it impossible to
> > inject faults independent of their context. Restore support for
> > task-independent fault injection by adding the attribute 'global'.
> 
> There was a the problem reported by fail-make-request user and the
> problem is introduced by the follow-up patches for systematic
> fault injection.
> 
> Please check the commit 9eeb52ae712e ("fault-inject: fix wrong
> should_fail() decision in task context") and see if the problem
> you reported is identical to the commit.

Hello Akinobu,

Since I was using the block layer for-next branch as the basis of my tests,
commit 9eeb52ae712e was not present in the kernel tree used in my tests.
However, with that commit 9eeb52ae712e applied I don't need my two patches
anymore to inject block layer timeout faults successfully. So I'm fine with
dropping my two patches.

Sorry for the noise.

Bart.