Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932568AbdHWTc6 (ORCPT ); Wed, 23 Aug 2017 15:32:58 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:28688 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbdHWTc4 (ORCPT ); Wed, 23 Aug 2017 15:32:56 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 23 Aug 2017 21:32:55 +0200 X-ME-IP: 90.55.206.157 From: Robert Jarzmik To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: pxa: fix possible race condition References: <20170821155742.22290-1-alexandre.belloni@free-electrons.com> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 23 Aug 2017 21:32:54 +0200 Message-ID: <87inheqduh.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 416 Lines: 13 Alexandre Belloni writes: > pxa_rtc_open() registers the interrupt handler which will access the RTC > registers. However, pxa_rtc_open() is called before the register range is > ioremapped. Instead, call it after devm_ioremap(). > > Signed-off-by: Alexandre Belloni Acked-by: Robert Jarzmik Cheers. -- Robert