Date: Wed, 23 Aug 2017 16:03:19 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Sandeep Singh <Sandeep.Singh@amd.com>
Cc: mathias.nyman@intel.com, ben@decadent.org.uk,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected
Message-ID: <20170823230319.GC5193@kroah.com>
References: <1503485760-15146-1-git-send-email-Sandeep.Singh@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1503485760-15146-1-git-send-email-Sandeep.Singh@amd.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 862
Lines: 26

On Wed, Aug 23, 2017 at 04:26:00PM +0530, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@amd.com>
> 
> The following commit cause a regression on ATI chipsets.
> 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain
> failing HP keyboard on reset after resume")'
> 
> This causes pinfo->smbus_dev to be wrongly set to NULL on
> systems with the ATI chipset that this function checks for first.
> 
> Added conditional check for AMD chipsets to avoid the overwriting
> pinfo->smbus_dev.
> 
> Reported-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Sandeep Singh <Sandeep.Singh@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>

A "Fixes:" tag here would be good, as would a "cc:
stable@vger.kernel.org" right?

And you have tested this out well, right?

thanks,

greg k-h