Subject: Re: [PATCH v2] sched/topology: Introduce NUMA identity node sched
 domain
To: Borislav Petkov <bp@suse.de>
References: <1502437275-1842-1-git-send-email-suravee.suthikulpanit@amd.com>
 <20170814174313.xkt76wqzwismprls@pd.tnic>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Message-ID: <e7a3ac18-81a4-1400-b73c-eb79d30aa8be@amd.com>
Date: Thu, 24 Aug 2017 08:13:23 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170814174313.xkt76wqzwismprls@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2017 01:13:39.4636 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1738
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1552
Lines: 44

Boris,

Sorry for late reply. I missed this email earlier.

On 8/15/17 00:43, Borislav Petkov wrote:
>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>> index 79895ae..2dd5b11 100644
>> --- a/kernel/sched/topology.c
>> +++ b/kernel/sched/topology.c
>> @@ -1335,6 +1335,10 @@ void sched_init_numa(void)
>>  	if (!sched_domains_numa_distance)
>>  		return;
>>
>> +	/* Includes NUMA identity node at level 0. */
>> +	sched_domains_numa_distance[level++] = curr_distance;
>> +	sched_domains_numa_levels = level;
>> +
>>  	/*
>>  	 * O(nr_nodes^2) deduplicating selection sort -- in order to find the
>>  	 * unique distances in the node_distance() table.
>> @@ -1382,8 +1386,7 @@ void sched_init_numa(void)
>>  		return;
>>
>>  	/*
>> -	 * 'level' contains the number of unique distances, excluding the
>> -	 * identity distance node_distance(i,i).
> I'm still unclear as to why were we excluding this identity distance
> until now and how would that change affect existing systems.

One reason that I can think of is that, on older systems (at least for AMD), L3 
sched domain level has the same cpumask as the node level. This is not the case 
for Zen.

> Also, you do use the term "NUMA" pretty loosely in the text - please
> take care to explain precisely what kind of node you mean: physical,
> logical, ... Don't be afraid to be too verbose.
>
> Thanks.

Mostly, I am referring to the logical NUMA (as described by the SRAT/SLIT), 
which can change based on how BIOS configures the system. I will update this in V3.

Thanks,
Suravee