Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbdHXEau (ORCPT ); Thu, 24 Aug 2017 00:30:50 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:38706 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbdHXEat (ORCPT ); Thu, 24 Aug 2017 00:30:49 -0400 Date: Thu, 24 Aug 2017 13:30:38 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] zram: add zstd to the supported algorithms list Message-ID: <20170824043038.GA13922@bgram> References: <20170824014936.4738-1-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824014936.4738-1-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 52 Hello Sergey, On Thu, Aug 24, 2017 at 10:49:36AM +0900, Sergey Senozhatsky wrote: > Add ZSTD to the list of supported compression algorithms. > > Official benchmarks [1]: First of all, thanks for the work! I want to ask one thing. Could you add some benchmark(e.g.,) result(comp ratio and speed) compared to (inflate, lzo, lz4)? I want to see how much it's good for small data that ours is 4K. Thanks! > > Compressor name Ratio Compression Decompress. > zstd 1.1.3 -1 2.877 430 MB/s 1110 MB/s > zlib 1.2.8 -1 2.743 110 MB/s 400 MB/s > brotli 0.5.2 -0 2.708 400 MB/s 430 MB/s > quicklz 1.5.0 -1 2.238 550 MB/s 710 MB/s > lzo1x 2.09 -1 2.108 650 MB/s 830 MB/s > lz4 1.7.5 2.101 720 MB/s 3600 MB/s > snappy 1.1.3 2.091 500 MB/s 1650 MB/s > lzf 3.6 -1 2.077 400 MB/s 860 MB/s > > [1] https://github.com/facebook/zstd > > Signed-off-by: Sergey Senozhatsky > --- > drivers/block/zram/zcomp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c > index 5b8992beffec..cc66daec7bbc 100644 > --- a/drivers/block/zram/zcomp.c > +++ b/drivers/block/zram/zcomp.c > @@ -31,6 +31,9 @@ static const char * const backends[] = { > #endif > #if IS_ENABLED(CONFIG_CRYPTO_842) > "842", > +#endif > +#if IS_ENABLED(CONFIG_CRYPTO_ZSTD) > + "zstd", > #endif > NULL > }; > -- > 2.14.1 >