Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbdHXGLO (ORCPT ); Thu, 24 Aug 2017 02:11:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:40030 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751111AbdHXGLN (ORCPT ); Thu, 24 Aug 2017 02:11:13 -0400 Subject: Re: [PATCH] xen: Don't try to call xen_alloc_p2m_entry() on autotranslating guests To: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1503527224-12390-1-git-send-email-boris.ostrovsky@oracle.com> From: Juergen Gross Message-ID: Date: Thu, 24 Aug 2017 08:11:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503527224-12390-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 18 On 24/08/17 00:27, Boris Ostrovsky wrote: > Commit aba831a69632 ("xen: remove tests for pvh mode in pure pv paths") > removed XENFEAT_auto_translated_physmap test in xen_alloc_p2m_entry() > since it is assumed that the routine is never called by non-PV guests. > > However, alloc_xenballooned_pages() may make this call on a PVH guest. > Prevent this from happening by adding XENFEAT_auto_translated_physmap > check there. > > Signed-off-by: Boris Ostrovsky > Fixes: aba831a69632 ("xen: remove tests for pvh mode in pure pv paths") Reviewed-by: Juergen Gross Thanks, Juergen