Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751276AbdHXHmC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 03:42:02 -0400
Received: from mga04.intel.com ([192.55.52.120]:22614 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751124AbdHXHmB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 03:42:01 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,420,1498546800"; 
   d="scan'208";a="893618665"
Message-ID: <1503560349.25945.72.camel@linux.intel.com>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tom Rini <trini@konsulko.com>
Cc: linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        Mark Brown <broonie@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 24 Aug 2017 10:39:09 +0300
In-Reply-To: <20170824000525.GY17193@bill-the-cat>
References: <1503453106-5564-1-git-send-email-trini@konsulko.com>
         <1503498573.25945.69.camel@linux.intel.com>
         <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1839
Lines: 64

On Wed, 2017-08-23 at 20:05 -0400, Tom Rini wrote:
> On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > 
> > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > Not all devices with ACPI and this combination of sound devices
> > > > will
> > > > have the required information provided via ACPI.  Reintroduce
> > > > the I2C
> > > > device ID to restore sound functionality on on the Chromebook
> > > > 'Samus'
> > > > model.
> > > > This is a regression from v4.12 on my laptop (a Chromebook
> > > > 'Samus'
> > > > that's not running ChromeOS).  My fault for getting out of the
> > > > habit
> > > > of
> > > > trying -rc1 when it comes out and not spotting this sooner.  I'm
> > > > not
> > > > 100% sure if this fix is correct for all cases as I'm only able
> > > > to
> > > > test
> > > > my hardware here, and this does fix my laptop.
> > > 
> > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform
> > > data
> > > in the module sources") does not fix your issue?
> > 
> > As that's not in master yet I can't tell.  Can you give me a pointer
> > to
> > somewhere?

It's in ASoC next at least.

> >   Thanks!
> 
> OK, my bad, it has a different hash upstream, but no, that change
> doesn't fix things as I see the problem on top of Linus'
> tree.  Thanks!

Interesting...

The only bug so far I saw is the following one

https://bugzilla.kernel.org/show_bug.cgi?id=196397

...and above commit fixes it.

Can you place somewhere the bundle of the following:

1. Output file (tables.dat) of
	% acpidump -o tables.dat
2. Output of
	% cat /proc/interrupts
3. Output of
	% lspci -vv -xx
4. Output of
	% grep -H 15 /sys/bus/acpi/devices/*/status

?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy