Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751276AbdHXH6S (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 03:58:18 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:43944 "EHLO
        youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751135AbdHXH6Q (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 03:58:16 -0400
MIME-Version: 1.0
In-Reply-To: <20170821100333.3538-1-dmitry@daynix.com>
References: <20170821100333.3538-1-dmitry@daynix.com>
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Thu, 24 Aug 2017 15:58:13 +0800
Message-ID: <CAAd53p4kbCNGPeVbASE_-wUWAkUMhdbHbOADRFUhqSSCK3HLvw@mail.gmail.com>
Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C920-C
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Devin Heitmueller <dheitmueller@kernellabs.com>,
        =?UTF-8?B?THVrw6HFoSBMYWxpbnNrw70=?= <lukas@oxygene.sk>,
        USB list <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1208
Lines: 33

On Mon, Aug 21, 2017 at 6:03 PM, Dmitry Fleytman <dmitry@daynix.com> wrote:
> Commit e0429362ab15
> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
> introduced quirk to workaround an issue with some Logitech webcams.
>
> Apparently model C920-C has the same issue so applying
> the same quirk as well.

I think it's better to also mention "C920-C" in the comment section.

>
> See aforementioned commit message for detailed explanation of the problem.
>
> Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
> ---
>  drivers/usb/core/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 574da2b..36d4841 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
>
>         /* Logitech HD Pro Webcams C920 and C930e */
>         { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
> +       { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
>         { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
>
>         /* Logitech ConferenceCam CC3000e */
> --
> 2.7.4
>