Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbdHXIhq (ORCPT ); Thu, 24 Aug 2017 04:37:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:50646 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751191AbdHXIhp (ORCPT ); Thu, 24 Aug 2017 04:37:45 -0400 Date: Thu, 24 Aug 2017 10:37:36 +0200 From: Borislav Petkov To: Suravee Suthikulpanit Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org Subject: Re: [PATCH v2] sched/topology: Introduce NUMA identity node sched domain Message-ID: <20170824083736.a36ivkhgb34g2lny@pd.tnic> References: <1502437275-1842-1-git-send-email-suravee.suthikulpanit@amd.com> <20170814174313.xkt76wqzwismprls@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 526 Lines: 15 On Thu, Aug 24, 2017 at 08:13:23AM +0700, Suravee Suthikulpanit wrote: > One reason that I can think of is that, on older systems (at least for AMD), > L3 sched domain level has the same cpumask as the node level. This is not > the case for Zen. So please write that in the commit message. You're changing code which runs on older systems so the impact (or the absence of it) has to be clear. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --