Date: Thu, 24 Aug 2017 10:54:42 +0100
From: Liviu Dudau <liviu.dudau@arm.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
        mturquette@baylibre.com, sboyd@codeaurora.org,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: versatile: make clk_ops const
Message-ID: <20170824095442.GC11316@e110455-lin.cambridge.arm.com>
References: <1503410786-25519-1-git-send-email-bhumirks@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1503410786-25519-1-git-send-email-bhumirks@gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1233
Lines: 45

On Tue, Aug 22, 2017 at 07:36:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a
> clk_init_data structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Thanks for the patch!

Sudeep, can you going to pick this up for 4.14?

Best regards,
Liviu

> ---
>  drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
> index 7e5add7..e7a868b 100644
> --- a/drivers/clk/versatile/clk-vexpress-osc.c
> +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> @@ -61,7 +61,7 @@ static int vexpress_osc_set_rate(struct clk_hw *hw, unsigned long rate,
>  	return regmap_write(osc->reg, 0, rate);
>  }
>  
> -static struct clk_ops vexpress_osc_ops = {
> +static const struct clk_ops vexpress_osc_ops = {
>  	.recalc_rate = vexpress_osc_recalc_rate,
>  	.round_rate = vexpress_osc_round_rate,
>  	.set_rate = vexpress_osc_set_rate,
> -- 
> 1.9.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯