Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbdHXKkb (ORCPT ); Thu, 24 Aug 2017 06:40:31 -0400 Received: from foss.arm.com ([217.140.101.70]:39150 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbdHXKka (ORCPT ); Thu, 24 Aug 2017 06:40:30 -0400 From: Marc Zyngier To: Bhumika Goyal Cc: julia.lawall@lip6.fr, tglx@linutronix.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: mmp: make mmp_intc_conf const In-Reply-To: <1503570381-8541-1-git-send-email-bhumirks@gmail.com> (Bhumika Goyal's message of "Thu, 24 Aug 2017 15:56:21 +0530") Organization: ARM Ltd References: <1503570381-8541-1-git-send-email-bhumirks@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Thu, 24 Aug 2017 11:40:26 +0100 Message-ID: <8760dd9rl1.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 54 On Thu, Aug 24 2017 at 3:56:21 pm BST, Bhumika Goyal wrote: > Make these const as they are only used during a copy operation. Done > using Coccinelle. > > @match disable optional_qualifier@ > identifier s; > @@ > static struct mmp_intc_conf s = {...}; > > @ref@ > position p; > identifier match.s; > @@ > s@p > > @good1@ > position ref.p; > identifier match.s,f,c; > expression e; > @@ > ( > e = s@p > | > e = s@p.f > | > c(...,s@p.f,...) > | > c(...,s@p,...) > ) > > @bad depends on !good1@ > position ref.p; > identifier match.s; > @@ > s@p > > @depends on forall !bad disable optional_qualifier@ > identifier match.s; > @@ > static > + const > struct mmp_intc_conf s; > > Signed-off-by: Bhumika Goyal Can you please post these fixes as a series instead of individual patches? It would make the maintainers' life much easier. I'll apply this patch anyway, but please keep this in mind for the future. Thanks, M. -- Jazz is not dead, it just smell funny.