Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751708AbdHXLKU (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 07:10:20 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:5016 "EHLO
        szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751249AbdHXLKT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 07:10:19 -0400
Subject: Re: [PATCH v5 0/4] Add support for ThunderX2 pmu events using json
 files
To: Ganapatrao Kulkarni <gklkml16@gmail.com>
References: <20170816071048.26087-1-ganapatrao.kulkarni@cavium.com>
 <CAKTKpr79hBBGfkVnKS+XsSOAwR9G1=F04OH0UBE3J8EX_w3L5A@mail.gmail.com>
 <4900f29c-aea5-9792-ee4b-adbf942eb361@huawei.com>
 <CAKTKpr6KB3VQ0bg-nA02T2-o9D1WbqS9UAinCN7YYwVd=MhyWg@mail.gmail.com>
CC: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
        "Arnaldo Carvalho de Melo" <acme@kernel.org>,
        Will Deacon <Will.Deacon@arm.com>, <mark.rutland@arm.com>,
        <alexander.shishkin@linux.intel.com>, <catalin.marinas@arm.com>,
        <Zi.Lim@cavium.com>, <linux-kernel@vger.kernel.org>,
        Zhangshaokun <zhangshaokun@hisilicon.com>, <peterz@infradead.org>,
        <Robert.Richter@cavium.com>, <mingo@redhat.com>,
        <jnair@caviumnetworks.com>, <linux-arm-kernel@lists.infradead.org>,
        Ganapatrao Kulkarni <gpkulkarni@gmail.com>,
        Linuxarm <linuxarm@huawei.com>
From: John Garry <john.garry@huawei.com>
Message-ID: <42ca65f2-35bf-4ea4-47ec-9e19ac954466@huawei.com>
Date: Thu, 24 Aug 2017 12:08:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAKTKpr6KB3VQ0bg-nA02T2-o9D1WbqS9UAinCN7YYwVd=MhyWg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.203.181.160]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
        refid=str=0001.0A090203.599EB3D8.0082,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
        ip=0.0.0.0,
        so=2014-11-16 11:51:01,
        dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 16f9fd76180c4f222e3c89609c6d9409
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3512
Lines: 115

On 24/08/2017 08:23, Ganapatrao Kulkarni wrote:
> Hi John,
>
> On Wed, Aug 23, 2017 at 2:52 PM, John Garry <john.garry@huawei.com> wrote:
>> On 22/08/2017 05:21, Ganapatrao Kulkarni wrote:
>>>
>>> Hi Arnaldo, Will,
>>>
>>> are there any comments on this series?
>>>
>>
>> Hi Ganapatrao,
>>
>> Is it possible to have vendor sub-folder in tools/perf/pmu-events/arch/arm64
>> folder (like arm64 device tree files)? We (HiSilicon) want to add support
>> for our hip08 SoC, and I don't think "hip08" or "<internal code name for
>> core>" are good arch sub-folder names.
>
> at present the directory structure is in-line with as done for x86 and powerpc.
> there can be separate patchset to have directory hierarchy as
> suggested by you, if every one agrees on it!

Fine.

BTW, Shaokun has a json file for our hip08 platform waiting, based on 
this current patchset. We can send it now if anyone wants to see another 
arm64 json.

Much appreciated,
John

>
>>
>> I am not sure if this way discussed before, but the changelog does not
>> mention it. And I think that we had the same location for thunderx2 in v1
>> series.
>>
>> We should also consider that in theory the events could change per SoC using
>> the same custom ARMv8 custom implementation.
>>
>> Thanks,
>> John
>>
>>>
>>> On Wed, Aug 16, 2017 at 12:40 PM, Ganapatrao Kulkarni
>>> <ganapatrao.kulkarni@cavium.com> wrote:
>>>>
>>>> Extending json/jevent framework for parsing arm64 event files.
>>>> Adding jevents for ThunderX2 implementation defined PMU events.
>>>>
>>>> v5:
>>>>    - Addressed comments from Arnaldo.
>>>>    - Rebased to 4.13-rc5
>>>>
>>>> v4:
>>>>    - Rebased to 4.13-rc1
>>>>
>>>> v3:
>>>>    - Addressed comments from Will Deacon and Jayachandran C.
>>>>    - Rebased to 4.12-rc1
>>>>
>>>> v2:
>>>>    - Updated as per Mark Rutland's suggestions.
>>>>    - Added provision for get_cpuid_str to get cpu id string
>>>>      from associated cpus of pmu core device.
>>>>
>>>> v1: Initial patchset.
>>>>
>>>> Ganapatrao Kulkarni (4):
>>>>   perf utils: passing pmu as a parameter to function get_cpuid_str
>>>>   perf tools arm64: Add support for get_cpuid_str function.
>>>>   perf utils: Add helper function is_pmu_core to detect PMU CORE devices
>>>>   perf vendor events arm64: Add ThunderX2 implementation defined pmu
>>>>     core events
>>>>
>>>>  tools/perf/arch/arm64/util/Build                   |  1 +
>>>>  tools/perf/arch/arm64/util/header.c                | 61
>>>> +++++++++++++++++++++
>>>>  tools/perf/arch/powerpc/util/header.c              |  2 +-
>>>>  tools/perf/arch/x86/util/header.c                  |  2 +-
>>>>  tools/perf/pmu-events/arch/arm64/mapfile.csv       | 15 ++++++
>>>>  .../arm64/thunderx2/implementation-defined.json    | 62
>>>> ++++++++++++++++++++++
>>>>  tools/perf/util/header.h                           |  3 +-
>>>>  tools/perf/util/pmu.c                              | 53
>>>> +++++++++++++++---
>>>>  8 files changed, 188 insertions(+), 11 deletions(-)
>>>>  create mode 100644 tools/perf/arch/arm64/util/header.c
>>>>  create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
>>>>  create mode 100644
>>>> tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
>>>>
>>>> --
>>>> 2.9.4
>>>>
>>>
>>> thanks
>>> Ganapat
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>>
>>> .
>>>
>>
>>
>
> thanks
> Ganapat
>
> .
>