Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbdHXMSg (ORCPT ); Thu, 24 Aug 2017 08:18:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:51338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdHXMSe (ORCPT ); Thu, 24 Aug 2017 08:18:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C03E021A29 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=shawnguo@kernel.org Date: Thu, 24 Aug 2017 20:18:20 +0800 From: Shawn Guo To: Stephen Boyd Cc: Kiran Gunda , gregkh@linuxfoundation.org, Rob Herring , Mark Rutland , Abhijeet Dharmapurikar , David Collins , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally Message-ID: <20170824121818.GE3685@dragon> References: <1503070110-15018-1-git-send-email-kgunda@codeaurora.org> <20170822085541.GB3685@dragon> <20170822203132.GC21656@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822203132.GC21656@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 808 Lines: 19 On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > Also, I see that on v4.13-rc series the read/write checks are > causing the led driver to fail in a different way: > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 > qcom-spmi-gpio 200f000.spmi:pm8916@0:gpios@c000: write 0x40 failed > leds-gpio soc:leds: Error applying setting, reverse things back > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc041 > qcom-spmi-gpio 200f000.spmi:pm8916@0:gpios@c000: write 0x41 failed > leds-gpio: probe of soc:leds failed with error -1 > > Are you seeing similar behavior? Yes. I forgot to mention that, and leds-gpio failure is gone after applying Kiran's patch below. spmi: pmic-arb: remove the read/write access checks Shawn