Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752912AbdHXMTT (ORCPT ); Thu, 24 Aug 2017 08:19:19 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:63180 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbdHXMTR (ORCPT ); Thu, 24 Aug 2017 08:19:17 -0400 Subject: Re: [PATCH] ARM: OMAP2+: fix missing variable declaration To: Laurent Pinchart , Arnd Bergmann CC: Tony Lindgren , , , References: <20170823132841.642239-1-arnd@arndb.de> <12875092.dy1RW0XmqV@avalon> From: Tomi Valkeinen Message-ID: <02160c46-d0c1-dc49-2f4f-01d46d9f7723@ti.com> Date: Thu, 24 Aug 2017 15:18:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <12875092.dy1RW0XmqV@avalon> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7OCJNEJ001396 Content-Length: 1027 Lines: 32  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 23/08/17 16:53, Laurent Pinchart wrote: > Hi Arnd, > > On Wednesday, 23 August 2017 16:28:19 EEST Arnd Bergmann wrote: >> The function that was added doesn't actually build: >> >> arch/arm/mach-omap2/display.c: In function 'omapdss_init_fbdev': >> arch/arm/mach-omap2/display.c:184:2: error: 'r' undeclared (first use in >> this function) >> >> This adds a declaration for 'r' to fix it. >> >> Fixes: 5ce783025c82 ("ARM: OMAP2+: Don't register omapdss device for >> omapdrm") >> Signed-off-by: Arnd Bergmann > > Looks like I haven't tested the patch with CONFIG_FB_OMAP2 enabled after the > last rebase. I'm very sorry about that :-( > > Reviewed-by: Laurent Pinchart > > Tomi, I assume you will pick this up and sent it to Dave for v4.14-rc1. Yep, I'll pick it up. I could swear I tested omapfb build, but... Obviously not. Tomi