Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbdHXNVQ (ORCPT ); Thu, 24 Aug 2017 09:21:16 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42925 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbdHXNTt (ORCPT ); Thu, 24 Aug 2017 09:19:49 -0400 Date: Thu, 24 Aug 2017 15:19:38 +0200 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, nadavh@marvell.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, mw@semihalf.com, stefanc@marvell.com, miquel.raynal@free-electrons.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum Message-ID: <20170824131938.GB8022@lunn.ch> References: <20170824083823.16826-1-antoine.tenart@free-electrons.com> <20170824083823.16826-2-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824083823.16826-2-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 451 Lines: 13 On Thu, Aug 24, 2017 at 10:38:11AM +0200, Antoine Tenart wrote: > This patch adds more PHY modes to the phy_mode enum, to allow > configuring PHYs to the SGMII and/or the 10GKR mode by using the > set_mode callback. Hi Antoine You had me confused for a while here. If there is need for a respin, could you change the commit log and prefix PHY with either generic or Ethernet, just to make it clear which PHY subsystem we are talking about. Andrew