Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbdHXOQI (ORCPT ); Thu, 24 Aug 2017 10:16:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24624 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752855AbdHXOQH (ORCPT ); Thu, 24 Aug 2017 10:16:07 -0400 Date: Thu, 24 Aug 2017 17:15:48 +0300 From: Dan Carpenter To: Janani Sankara Babu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, insafonov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:rtl8188eu:core Fix Avoid CamelCase Message-ID: <20170824141547.k4jpi3kuy5rhu3le@mwanda> References: <1503566886-6566-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503566886-6566-1-git-send-email-jananis37@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1963 Lines: 38 On Thu, Aug 24, 2017 at 02:58:06PM +0530, Janani Sankara Babu wrote: > This patch is created to solve the CamelCase issue. The members 'IEs' and > 'IELength' of struct wlan_bssid_ex are being modified to 'ies' and > 'ie_length' to solve the issue. And all the places where these variables > are referenced inside the rtl8188eu driver are also changed. > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 89 +++++++++++---------- > drivers/staging/rtl8188eu/core/rtw_cmd.c | 26 +++--- > drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 20 ++--- > drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 +- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 66 ++++++++-------- > drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 100 ++++++++++++------------ > drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 34 ++++---- > drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 16 ++-- > drivers/staging/rtl8188eu/include/wlan_bssdef.h | 10 +-- > drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +-- > 10 files changed, 189 insertions(+), 186 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c > index 647a922..2cd20f1 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_ap.c > +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c > @@ -69,19 +69,22 @@ static void update_BCNTIM(struct adapter *padapter) > struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; > struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; > struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network; > - unsigned char *pie = pnetwork_mlmeext->IEs; > + //unsigned char *pie = pnetwork_mlmeext->ies; > + unsigned char *pie = pnetwork_mlmeext->ies; Why did you comment this out? Really "ie" is a better name that "ies". The "s" was supposed to make it plural but that's not obvious in the new code. regards, dan carpenter