Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753201AbdHXOb1 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 10:31:27 -0400
Received: from mx2.suse.de ([195.135.220.15]:48911 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1752973AbdHXOb0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 10:31:26 -0400
Date: Thu, 24 Aug 2017 16:31:25 +0200
Message-ID: <s5hinhdjav6.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Tom Rini" <trini@konsulko.com>
Cc: <alsa-devel@alsa-project.org>, "Liam Girdwood" <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
        "Bard Liao" <bardliao@realtek.com>,
        "Oder Chiou" <oder_chiou@realtek.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
In-Reply-To: <s5hk21tjb02.wl-tiwai@suse.de>
References: <1503453106-5564-1-git-send-email-trini@konsulko.com>
        <1503498573.25945.69.camel@linux.intel.com>
        <20170823173912.GN17193@bill-the-cat>
        <20170824000525.GY17193@bill-the-cat>
        <s5hk21tjb02.wl-tiwai@suse.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1443
Lines: 36

On Thu, 24 Aug 2017 16:28:29 +0200,
Takashi Iwai wrote:
> 
> On Thu, 24 Aug 2017 02:05:25 +0200,
> Tom Rini wrote:
> > 
> > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > 
> > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > > > Not all devices with ACPI and this combination of sound devices will
> > > > > have the required information provided via ACPI.  Reintroduce the I2C
> > > > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > > > model.
> > > > 
> > > > > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > > > > that's not running ChromeOS).  My fault for getting out of the habit
> > > > > of
> > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > > > > 100% sure if this fix is correct for all cases as I'm only able to
> > > > > test
> > > > > my hardware here, and this does fix my laptop.
> > > > 
> > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> > > > in the module sources") does not fix your issue?
> > > 
> > > As that's not in master yet I can't tell.  Can you give me a pointer to
> > > somewhere?  Thanks!
> > 
> > OK, my bad, it has a different hash upstream,

BTW, the hash above is correct.  It's in Mark's asoc tree (and in
linux-next).  You might have cherry-picked a wrong one, I suppose?


Takashi