Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbdHXPrA (ORCPT ); Thu, 24 Aug 2017 11:47:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47814 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbdHXPq6 (ORCPT ); Thu, 24 Aug 2017 11:46:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B2DE11E31B Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH 1/4] KVM: VMX: cache secondary exec controls To: Jim Mattson Cc: LKML , kvm list References: <1503581879-52125-1-git-send-email-pbonzini@redhat.com> <1503581879-52125-2-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 24 Aug 2017 17:46:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 24 Aug 2017 15:46:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 25 On 24/08/2017 17:41, Jim Mattson wrote: > Userspace can establish the value of the virtualized > IA32_VMX_PROCBASED_CTLS2 MSR via the KVM_SET_MSRS ioctl, which goes > through vms_set_vmx_msr. But maybe that's not important, since > features can only be disabled on that path. Yeah, I was only thinking of non-nested in the commit message. It's complicated enough. :) Paolo > On Thu, Aug 24, 2017 at 8:25 AM, Paolo Bonzini wrote: >> On 24/08/2017 16:47, Jim Mattson wrote: >>>> Currently, secondary execution controls are divided in three groups: >>>> >>>> - static, depending mostly on the module arguments or the processor >>>> (vmx_secondary_exec_control) >>>> >>>> - static, depending on CPUID (vmx_cpuid_update) >>> There should also be: >>> >>> - static, depending on guest VMX capability MSRs (vmx_set_vmx_msr) >> Can you explain what you mean? >> >> Paolo