DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A8F125277A
Subject: Re: [PATCH v3 2/5] KVM: MMU: check guest CR3 reserved bits based on
 its physical address width.
To: Yu Zhang <yu.c.zhang@linux.intel.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, xiaoguangrong@tencent.com,
        joro@8bytes.org
References: <1503577676-12345-1-git-send-email-yu.c.zhang@linux.intel.com>
 <1503577676-12345-3-git-send-email-yu.c.zhang@linux.intel.com>
 <0bce2df3-79ac-599b-19fa-8ebeaff23623@redhat.com>
 <b4af9303-57bb-76cd-297f-ccb9128daf29@linux.intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <35e285e7-168a-25e6-1053-c005da18c103@redhat.com>
Date: Thu, 24 Aug 2017 17:50:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <b4af9303-57bb-76cd-297f-ccb9128daf29@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 529
Lines: 20

On 24/08/2017 17:23, Yu Zhang wrote:
>>>
>>>     static inline u64 rsvd_bits(int s, int e)
>>>   {
>>> +    if (e < s)
>>> +        return 0;
>>> +
>>>       return ((1ULL << (e - s + 1)) - 1) << s;
>>>   }
>> e = s - 1 is already supported; why do you need e <= s - 2?
> 
> Sorry? I do not quite understand. When will e = s - 1?

Is there any case where e < s?  I can see that MAXPHYADDR=63 gives
rsvd_bits(63, 62), but that works.

In practice, MAXPHYADDR will never be 59 even because the PKRU bits are
at bits 59..62.

Paolo