Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753484AbdHXPyT (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 11:54:19 -0400
Received: from mx2.suse.de ([195.135.220.15]:59789 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751840AbdHXPyS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 11:54:18 -0400
Date: Thu, 24 Aug 2017 17:54:16 +0200
Message-ID: <s5h4lsxj713.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Tom Rini <trini@konsulko.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bard Liao <bardliao@realtek.com>, Oder Chiou <oder_chiou@realtek.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
In-Reply-To: <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk>
References: <1503453106-5564-1-git-send-email-trini@konsulko.com>
        <1503498573.25945.69.camel@linux.intel.com>
        <20170823173912.GN17193@bill-the-cat>
        <20170824000525.GY17193@bill-the-cat>
        <s5hk21tjb02.wl-tiwai@suse.de>
        <s5hinhdjav6.wl-tiwai@suse.de>
        <20170824144152.GC17193@bill-the-cat>
        <s5h60ddj7l8.wl-tiwai@suse.de>
        <20170824155235.2nrqjiwlo3afk4ei@sirena.org.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 750
Lines: 22

On Thu, 24 Aug 2017 17:52:35 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 05:42:11PM +0200, Takashi Iwai wrote:
> 
> > OK, so the fix for 4.13 would be either to cherry-pick this commit, or
> > just to re-add "RT5677CE:00" to i2c_id temporarily as a quick band-aid
> > fix (and remove again in 4.14).
> 
> > The former is cleaner, but it's bigger, while the latter is a safer
> > oneliner at the late RC stage.
> 
> > I leave the decision to Mark.
> 
> I'm happier with the oneline change TBH, like you say it's pretty late
> in the release cycle.  Can you just apply the patch directly and send it
> to Linus with my ack or should I put together a pull request?

OK, no problem, I'll add Tom's patch with a bit more explanations.


Takashi