Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538AbdHXP4D (ORCPT ); Thu, 24 Aug 2017 11:56:03 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:38455 "EHLO mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752681AbdHXP4C (ORCPT ); Thu, 24 Aug 2017 11:56:02 -0400 Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c To: Abishek V Ashok , gregkh@linuxfoundation.org, sumit.semwal@linaro.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170824154050.11345-1-abishekvashok@gmail.com> From: Laura Abbott Message-ID: Date: Thu, 24 Aug 2017 08:55:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170824154050.11345-1-abishekvashok@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 38 On 08/24/2017 08:40 AM, Abishek V Ashok wrote: > This is a patch to the ion_cma_heap.c file in > /drivers/staging/andrioid/ion that fixes a blank line and > kmalloc size warning found by the checkpatch.pl tool. > You've done two things in this patch, please stick to a single change per patch. > Signed-off-by: Abhishek V Ashok > --- > drivers/staging/android/ion/ion_cma_heap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c > index a0949bc0..1589b9e0 100644 > --- a/drivers/staging/android/ion/ion_cma_heap.c > +++ b/drivers/staging/android/ion/ion_cma_heap.c > @@ -31,7 +31,6 @@ struct ion_cma_heap { > > #define to_cma_heap(x) container_of(x, struct ion_cma_heap, heap) > > - > /* ION CMA heap operations functions */ > static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > unsigned long len, > @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!pages) > return -ENOMEM; > > - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL); > + table = kmalloc(sizeof(struct * table), GFP_KERNEL); > if (!table) > goto err; > > -- > 2.11.0 >