Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753678AbdHXQUn (ORCPT ); Thu, 24 Aug 2017 12:20:43 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:35477 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbdHXQUi (ORCPT ); Thu, 24 Aug 2017 12:20:38 -0400 Date: Thu, 24 Aug 2017 09:20:34 -0700 From: Christoffer Dall To: Arvind Yadav Cc: marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file_operations Message-ID: <20170824162034.GC2150@lvm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 38 On Wed, Aug 23, 2017 at 12:25:36PM +0530, Arvind Yadav wrote: > vgic_debug_seq_ops and file_operations are not supposed to change > at runtime and none of the structures is modified. > > Signed-off-by: Arvind Yadav Applied, thanks. -Christoffer > --- > virt/kvm/arm/vgic/vgic-debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/arm/vgic/vgic-debug.c b/virt/kvm/arm/vgic/vgic-debug.c > index 7072ab7..10b3817 100644 > --- a/virt/kvm/arm/vgic/vgic-debug.c > +++ b/virt/kvm/arm/vgic/vgic-debug.c > @@ -234,7 +234,7 @@ static int vgic_debug_show(struct seq_file *s, void *v) > return 0; > } > > -static struct seq_operations vgic_debug_seq_ops = { > +static const struct seq_operations vgic_debug_seq_ops = { > .start = vgic_debug_start, > .next = vgic_debug_next, > .stop = vgic_debug_stop, > @@ -255,7 +255,7 @@ static int debug_open(struct inode *inode, struct file *file) > return ret; > }; > > -static struct file_operations vgic_debug_fops = { > +static const struct file_operations vgic_debug_fops = { > .owner = THIS_MODULE, > .open = debug_open, > .read = seq_read, > -- > 1.9.1 >