Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753480AbdHXQeX convert rfc822-to-8bit (ORCPT ); Thu, 24 Aug 2017 12:34:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46818 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbdHXQeW (ORCPT ); Thu, 24 Aug 2017 12:34:22 -0400 Date: Thu, 24 Aug 2017 09:34:21 -0700 (PDT) Message-Id: <20170824.093421.154694549501118093.davem@davemloft.net> To: romain.perier@collabora.com Cc: f.fainelli@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] net: stmmac: Delete dead code for MDIO registration From: David Miller In-Reply-To: <10e0ebf9-b412-8547-d0d7-01a958edbcd9@collabora.com> References: <20170823085058.23333-1-romain.perier@collabora.com> <10e0ebf9-b412-8547-d0d7-01a958edbcd9@collabora.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Aug 2017 09:34:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 18 From: Romain Perier Date: Thu, 24 Aug 2017 08:49:18 +0200 > Le 23/08/2017 ? 18:46, Florian Fainelli a ?crit : >> On 08/23/2017 01:50 AM, Romain Perier wrote: >>> This code is no longer used, the logging function was changed by commit >>> fbca164776e4 ("net: stmmac: Use the right logging functi"). It was >>> previously showing information about the type if the IRQ, if it's polled, >>> ignored or a normal interrupt. As we don't want information loss, I have >>> moved this code to phy_attached_print(). >>> >>> Fixes: fbca164776e4 ("net: stmmac: Use the right logging functi") >> For future submissions, do not truncate the commit subject that you are >> referencing. > > Even if it exceeds 72 characters ? Yes, always.