Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbdHXQzJ (ORCPT ); Thu, 24 Aug 2017 12:55:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:49022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbdHXQzG (ORCPT ); Thu, 24 Aug 2017 12:55:06 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F6BC21A1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Thu, 24 Aug 2017 11:55:05 -0500 From: Bjorn Helgaas To: Jeffy Chen Cc: linux-kernel@vger.kernel.org, bhelgaas@google.com, Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-pci@vger.kernel.org, shawn.lin@rock-chips.com, briannorris@chromium.org, Will Deacon , dianders@chromium.org, Rob Herring , linux-rockchip@lists.infradead.org, Matthias Kaehlcke , Klaus Goger , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: Re: [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Message-ID: <20170824165505.GM31858@bhelgaas-glaptop.roam.corp.google.com> References: <20170822031934.8675-1-jeffy.chen@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822031934.8675-1-jeffy.chen@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 34 On Tue, Aug 22, 2017 at 11:19:30AM +0800, Jeffy Chen wrote: > > Currently we are handling pcie wake in mrvl wifi driver. But Brian > suggests to move it into rockchip pcie driver. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v4: > Rebase on newest for-next branch, also fix error handling by: > 1e7f570a1b86 PCI: rockchip: Idle inactive PHY(s) > > Changes in v3: > Fix error handling > > Changes in v2: > Use dev_pm_set_dedicated_wake_irq > -- Suggested by Brian Norris > > Jeffy Chen (4): > PCI: rockchip: Fix error handlings > PCI: rockchip: Add support for pcie wake irq > dt-bindings: PCI: rockchip: Add support for pcie wake irq > arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru > > .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++- > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 15 +- > drivers/pci/host/pcie-rockchip.c | 179 ++++++++++++--------- > 3 files changed, 126 insertions(+), 88 deletions(-) Looking for acks from Shawn and Rob... And I'm not sure about the DT wake IRQ description. That seems like it could potentially be generic than this Rockchip-specific proposal.