Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754048AbdHXRIt convert rfc822-to-8bit (ORCPT ); Thu, 24 Aug 2017 13:08:49 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:52997 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753271AbdHXRIr (ORCPT ); Thu, 24 Aug 2017 13:08:47 -0400 From: Stefan Chulski To: Antoine Tenart , Andrew Lunn CC: "davem@davemloft.net" , "kishon@ti.com" , "jason@lakedaemon.net" , "sebastian.hesselbarth@gmail.com" , "gregory.clement@free-electrons.com" , "thomas.petazzoni@free-electrons.com" , Nadav Haklai , "linux@armlinux.org.uk" , "linux-kernel@vger.kernel.org" , "mw@semihalf.com" , "miquel.raynal@free-electrons.com" , "netdev@vger.kernel.org" Subject: RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Thread-Topic: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Thread-Index: AQHTHPJEp2rrDs7CAUuOzOi8PUX9YKKTfWmAgAA9E7A= Date: Thu, 24 Aug 2017 17:08:29 +0000 Message-ID: References: <20170824083823.16826-1-antoine.tenart@free-electrons.com> <20170824083823.16826-10-antoine.tenart@free-electrons.com> <20170824145609.GJ8022@lunn.ch> <20170824155241.GF28443@kwain> <20170824160124.GA18700@lunn.ch> <20170824161945.GG28443@kwain> In-Reply-To: <20170824161945.GG28443@kwain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.203.130.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-24_06:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708240264 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 19 > > Imagine phylib is using the copper Ethernet PHY, but the MAC is using > > the SFP port. Somebody pulls out the copper cable, phylib says the > > link is down, turns the carrier off and calls the callback. Not good, > > since your SFP cable is still plugged in... Ethtool is > > returning/setting stuff in the Copper Ethernet PHY, when in fact you > > intend to be setting SFP settings. > > I see what could be the issue but I do not understand one aspect though: > how could we switch from one PHY to another, as there's only one output > between the SoC (and so a given GoP#) and the board. So if a given PHY can > handle multiple modes I see, but in the other case a muxing somewhere would > be needed? Or did I miss something? I think PHY name and PHY mode struct that describe here both MAC to PHY and PHY to PHY connection create confusion... Serdes IP lane doesn't care if connector is SFP, RJ45 or direct attached cable. mvpp22_comphy_init only configures MAC to PHY connection. SFI for 10G(KR in mainline), SGMII for 1G and HS_SGMII for 2.5G. Regards, Stefan.