Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbdHXRfb (ORCPT ); Thu, 24 Aug 2017 13:35:31 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:37218 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbdHXRf3 (ORCPT ); Thu, 24 Aug 2017 13:35:29 -0400 Subject: Re: [PATCH] clk: qcom: msm8916: Fix bimc gpu clock ops To: Stephen Boyd Cc: mturquette@baylibre.com, robdclark@gmail.com, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170818142250.27867-1-georgi.djakov@linaro.org> <20170823225543.GJ21656@codeaurora.org> From: Georgi Djakov Message-ID: Date: Thu, 24 Aug 2017 20:35:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170823225543.GJ21656@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 24 On 08/24/2017 01:55 AM, Stephen Boyd wrote: > On 08/18, Georgi Djakov wrote: >> The clock bimc_gpu_clk_src is incorrectly set to use the shared rcg2 >> ops, which are for RCGs with child branches controlled by different >> CPUs. >> >> The result of the incorrect ops is that the GPU's PM runtime may leave >> this clock set at a very low rate. Fix this issue by using the correct >> rcg2 ops. >> >> Fixes: a2e8272f3f89 ("clk: qcom: Add MSM8916 gpu clocks") >> Signed-off-by: Georgi Djakov >> --- > > This is the only user of clk_rcg2_shared_ops. I'm totally lost > why we added this in the first place. > Yes, this is the only user. It seems that the ops could be useful for a few other SoC that are not upstream yet, but for now i am sending a patch to remove the unused code. Thanks, Georgi