Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbdHXTIH (ORCPT ); Thu, 24 Aug 2017 15:08:07 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37075 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbdHXTIG (ORCPT ); Thu, 24 Aug 2017 15:08:06 -0400 Date: Thu, 24 Aug 2017 22:07:37 +0300 From: Dan Carpenter To: Abishek V Ashok Cc: labbott@redhat.com, gregkh@linuxfoundation.org, sumit.semwal@linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Message-ID: <20170824190737.wz4rbhrphuvumpqz@mwanda> References: <20170824154050.11345-1-abishekvashok@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824154050.11345-1-abishekvashok@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 372 Lines: 12 On Thu, Aug 24, 2017 at 09:10:50PM +0530, Abishek V Ashok wrote: > @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!pages) > return -ENOMEM; > > - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL); > + table = kmalloc(sizeof(struct * table), GFP_KERNEL); You didn't try compile this. regards, dan carpenter