Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753335AbdHXTR5 (ORCPT ); Thu, 24 Aug 2017 15:17:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42135 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdHXTRx (ORCPT ); Thu, 24 Aug 2017 15:17:53 -0400 Date: Thu, 24 Aug 2017 22:16:45 +0300 From: Dan Carpenter To: sandeen@redhat.com Cc: SF Markus Elfring , linux-ext4@vger.kernel.org, Andreas Dilger , "Theodore Ts'o" , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect() Message-ID: <20170824191645.ha3bw5n24lqcpxd7@mwanda> References: <5bf432ae-398d-718c-8105-3092a240a8ef@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 19 On Sat, Aug 19, 2017 at 12:08:29PM -0500, Eric Sandeen wrote: > On 8/19/17 6:47 AM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sat, 19 Aug 2017 13:04:50 +0200 > > > > Omit an extra message for a memory allocation failure in this function. > > I might be dense, but what makes this message "extra?" > > (I suppose kmalloc squawks too if it fails, but is Coccinelle > now warning about explicit memory allocation failure warnings?) > Yeah... Checkpatch complains that the kmalloc squawks is enough. "WARNING: Possible unnecessary 'out of memory' message". This allocation is small so it's guaranteed to succeed in current kernels. regards, dan carpenter