From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stefan Lippers-Hollmann <s.l-h@gmx.de>,
        Christian Brauner <christian.brauner@canonical.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Thorsten Leemhuis <regressions@leemhuis.info>
References: <20170816171211.4021-1-christian.brauner@ubuntu.com>
        <CA+55aFz+qGxM9MidcvQkP4er-qn0_oEqCac=ob64f+twhptSgQ@mail.gmail.com>
        <CA+55aFxXzwoDdN72m2oaV4XuxO0DGoT+Bp84i07VFpLQ3Ftcpw@mail.gmail.com>
        <87pobvruzt.fsf@xmission.com>
        <CA+55aFyJsxsxeW-8RX83AM2zs+_i8h85i99X+YkuFEqpqjtp4w@mail.gmail.com>
        <87ziazqdfr.fsf@xmission.com>
        <CA+55aFwssaZpapQdc2iVVmMt0KxTHYdeo71Xbp4Ex-pYP_MpMw@mail.gmail.com>
        <20170824022436.44adb497@mir>
        <CA+55aFzHa0vL2Yui05r6aSQM0-oHuUAjqi1kxheG_tFQRkUGYw@mail.gmail.com>
        <87378hhi3y.fsf@xmission.com>
        <CA+55aFxhg8=KMZDtF-TrVjb3fPNvSWUveuRy1HHGuWXQ3+YzwQ@mail.gmail.com>
        <CA+55aFw737C9OVC2nQgGcazhi7Ca2K-frzgN2MiD=XqqFAp8YA@mail.gmail.com>
        <CA+55aFwvwtFCH2THn1LirOpMsZ57pnNi61nXQfQ6NBgakdXpTQ@mail.gmail.com>
        <87wp5tfynr.fsf@xmission.com> <20170824062432.1e05e6f8@mir>
        <874lsxezal.fsf@xmission.com>
        <CA+55aFz62HAC=v0=wVDPwdSPRXAnPGoAec1o==22AqrQchUzUQ@mail.gmail.com>
        <CA+55aFyO-70cz3ByOmD3zWByy+1x20VK5UajLa1p_-Gi8Y1nQg@mail.gmail.com>
        <CA+55aFxiDZAcFvngiNGUT=o78i1SWZ-tSHDYV4TKebiixiD6Pg@mail.gmail.com>
        <87y3q8ermg.fsf@xmission.com>
        <CA+55aFy5qo3Gsfi9PY0QMtK=jAnKYohY2U3ohQefmqSMVx156g@mail.gmail.com>
Date: Thu, 24 Aug 2017 14:23:31 -0500
In-Reply-To: <CA+55aFy5qo3Gsfi9PY0QMtK=jAnKYohY2U3ohQefmqSMVx156g@mail.gmail.com>
        (Linus Torvalds's message of "Thu, 24 Aug 2017 11:51:05 -0700")
Message-ID: <87k21sepn0.fsf@xmission.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 33

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Thu, Aug 24, 2017 at 11:40 AM, Eric W. Biederman
> <ebiederm@xmission.com> wrote:
>>
>> Here is my tested version of the patch.
>
> Can you please take my cleanups to devpts_ptmx_path() too?

Let met take a look.  

> Those 'goto err' statements are disgusting, when a plain 'return
> -ERRNO' works cleaner.

Yes those look like good cleanups.  I had tried to preserve the original
logic in devpts_ptmx_path from devpts_acquire to make it easier to
see if I had goofed.   But that out and out failed so cleanups
so the code is easier to read look like a very good thing.

> And that "struct file *filp = NULL;" is bogus - you added the NULL
> initialization because you mis-used "filp" early, and with that fixed
> it's just garbage.

Actually the NULL initialization is a hold over from the original
version of that function.  But I agree without it gcc could have
caught my use of the wrong variable, so removing it looks like a good
idea.

> Other than that, it looks fine to me.

Thanks.  I will respin and retest and see where things are at.

Eric