Date: Thu, 24 Aug 2017 22:24:21 +0200
From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
        Christian Brauner <christian.brauner@canonical.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name
Message-ID: <20170824222421.7c59dd8e@mir>
In-Reply-To: <CA+55aFwKu3e1o=LFEYoSCtoLTXJhiMA1UL1mif2zEcikXn-EvQ@mail.gmail.com>
References: <20170816171211.4021-1-christian.brauner@ubuntu.com>
        <87ziazqdfr.fsf@xmission.com>
        <CA+55aFwssaZpapQdc2iVVmMt0KxTHYdeo71Xbp4Ex-pYP_MpMw@mail.gmail.com>
        <20170824022436.44adb497@mir>
        <CA+55aFzHa0vL2Yui05r6aSQM0-oHuUAjqi1kxheG_tFQRkUGYw@mail.gmail.com>
        <87378hhi3y.fsf@xmission.com>
        <CA+55aFxhg8=KMZDtF-TrVjb3fPNvSWUveuRy1HHGuWXQ3+YzwQ@mail.gmail.com>
        <CA+55aFw737C9OVC2nQgGcazhi7Ca2K-frzgN2MiD=XqqFAp8YA@mail.gmail.com>
        <CA+55aFwvwtFCH2THn1LirOpMsZ57pnNi61nXQfQ6NBgakdXpTQ@mail.gmail.com>
        <87wp5tfynr.fsf@xmission.com>
        <20170824062432.1e05e6f8@mir>
        <874lsxezal.fsf@xmission.com>
        <CA+55aFz62HAC=v0=wVDPwdSPRXAnPGoAec1o==22AqrQchUzUQ@mail.gmail.com>
        <CA+55aFyO-70cz3ByOmD3zWByy+1x20VK5UajLa1p_-Gi8Y1nQg@mail.gmail.com>
        <CA+55aFxiDZAcFvngiNGUT=o78i1SWZ-tSHDYV4TKebiixiD6Pg@mail.gmail.com>
        <CA+55aFw5VumaCsCB0dqj_+kYvwcBDVncju5-E4qRYY2Gikj=fw@mail.gmail.com>
        <CA+55aFwKu3e1o=LFEYoSCtoLTXJhiMA1UL1mif2zEcikXn-EvQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 893
Lines: 24

Hi

[ sorry for the re-send, this accidentally only reached you, rather than
 the mailing list and the other recipients as well ]

On 2017-08-24, Linus Torvalds wrote:
> On Thu, Aug 24, 2017 at 11:31 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > It should just do a "return ptm_open_peer(file, tty, (int)arg);" instead.  
> 
> Here's the actual tested patch. It "WorksForMe(tm)", including the
> TIOCGPTPEER ioctl, and also verified that it gets the pathname right
> in /proc, which was the original problem.
> 
> But I did *not* check that pbuilder is still happy. Stefan?

This patch seems to work, ssh, xterm (konsole5), real tty and pbuilder
(creating- and updating the build chroots, just as well as building 
several fairly involved packages) are fine with this patch on top of 
v4.13-rc6-66-g143c97cc6529 (tested on x86_64).

Thanks a lot
	Stefan Lippers-Hollmann